Skip to main content
Menu
Advisories

Validation bypass of Pydantic V1 dataclasses allowing extra data

GHSA-R49W-VH47-R4HFPublished Updated GitHub

Description

When extra data is allowed, providing a __pydantic_initialised__ key when validating a Pydantic V1 dataclass makes it considered as already validated, resulting in field values not being validated.

Details

When extra data is allowed, the __init__() method of Pydantic V1 dataclasses stores all the provided keyword arguments in the instance __dict__ before validation (pydantic/dataclasses.py):

elif config.extra == Extra.allow:
    for k, v in kwargs.items():
        self.__dict__.setdefault(k, v)
    init(self, *args, **{k: v for k, v in kwargs.items() if k in self.__dataclass_fields__})

A __pydantic_initialised__ keyword argument thus overrides the internal flag used to skip validation of already validated instances (pydantic/dataclasses.py):

def _dataclass_validate_values(self: 'Dataclass') -> None:
    # validation errors can occur if this function is called twice on an already initialised dataclass.
    # for example if Extra.forbid is enabled, it would consider __pydantic_initialised__ an invalid extra property
    if getattr(self, '__pydantic_initialised__'):
        return

The issue was fixed in commit github.com/pydantic/pydantic/commit/b26913fe6, published in V1.10.27.

If you are relying on the pydantic.v1 namespace in Pydantic V2, upgrade to V2.14.2 or later.

Impact

Validation bypass: data returned by validation doesn't match the declared type. Affected are applications validating untrusted data into Pydantic V1 dataclasses allowing extra data (with extra=Extra.allow).

Affected versions

References

GitHub · pydantic/pydantic