Skip to main content
Menu
Advisories

Quadratic time timedelta validation in Pydantic V1

GHSA-JFV7-GHGV-GX4XPublished Updated GitHub

Description

Validating an untrusted ISO 8601 duration string into a timedelta field with Pydantic V1 takes quadratic time: an input of a few dozen kilobytes takes seconds to validate.

Details

The iso8601_duration_re regular expression used to parse ISO 8601 durations (in pydantic/datetime_parse.py) contains an unescaped ., which also matches digits:

iso8601_duration_re = re.compile(
    r'^(?P<sign>[-+]?)'
    r'P'
    r'(?:(?P<days>\d+(.\d+)?)D)?'
    r'(?:T'
    r'(?:(?P<hours>\d+(.\d+)?)H)?'
    r'(?:(?P<minutes>\d+(.\d+)?)M)?'
    r'(?:(?P<seconds>\d+(.\d+)?)S)?'
    r')?'
    r'$'
)

On a string of digits, the repeated groups overlap and the regex engine backtracks in quadratic time.

The issue was fixed in commit github.com/pydantic/pydantic/commit/62791e66a9f8f118e465ed760c9e2ede9ae3055e.

If you are relying on the pydantic.v1 namespace in Pydantic V2, upgrade to V2.14.2 or later.

Impact

Denial of service through validation of untrusted input. Affected are applications validating untrusted strings into timedelta fields.

Affected versions

References

GitHub · pydantic/pydantic