Skip to main content
← All vulnerabilities
GHSA-H4FR-CMH5-QR62

Fallow: A `.*` glob segment let an analyzed repository make Fallow test paths in the parent of the project root

Published
Last modified
published
Not listed in CISA KEV
Low (ghsa)
Fix
Fixed in 3.34.0
None on Exploit-DB, Metasploit or GitHub

Summary

Fallow, a tool that analyzes JavaScript/TypeScript repositories for unused code and dependencies, is affected before version 3.34.0. A malicious repository could use wildcard glob patterns to check whether files or directories exist in the parent of the project root, with the results visible in Fallow's output such as CI logs or pull request comments.

Summarized by anthropic/claude-haiku-5.5. Verify details against the original sources.

Read the original description

Impact Fallow expands some globs from the analyzed repository on disk. Before 3.34.0, a segment such as `.*`, `.?` or `..*` in such a glob also matched the special `..` entry. The `glob` crate tests `..` against a segment that starts with a literal `.`. Fallow validates plugin glob patterns and refuses absolute paths and `..` segments, but these segments passed that validation. The attacker controls the repository content. The attacker must also be able to read the Fallow output, for example a CI log or a pull request comment. Then the attacker can learn if a file or directory exists in the parent of the project root: • A plugin `fileExists` detection pattern such as `.*/marker.json` made the plugin active when `marker.json` existed in the parent directory. • An external plugin `configPatterns` or `alwaysUsed` pattern could match a config file in the parent directory. When the plugin was active and declared `toolingDependencies`, the tooling detection credited the related dev dependency. An unused dependency finding could then disappear, and `--trace-dependency` printed the outside path. • `fallow plugin-check` reported `path_exists: true` for a seeded entry that matched only in the parent directory. Fallow tested only that these paths exist. It did not read or print the content of a file outside the project root through these globs. The Jest, Vitest and Rstest project globs had the same `.*` problem, and the Jest and Vitest ones also read file content. GHSA-jfwm-3p3c-6hx5 describes that case. Patches Fixed in 3.34.0. Fallow now rewrites a leading `.` in a wildcard segment to `[.]` before it expands the glob on disk. `[.]` matches the same hidden files and directories inside the project root. The `glob` crate does not test `..` against it. Workarounds Run Fallow only on repositories that you trust. Before you run Fallow on another repository, check the `detection`, `configPatterns` and `alwaysUsed` patterns of its plugin files.

Timeline

  1. Advisory published
  2. Record last updated
  3. First seen by cve.now

Affected versions

  • fallownpm

    fixed in 3.34.0

  • @fallow-cli/fallow-nodenpm

    fixed in 3.34.0

  • fallow-clicrates.io

    fixed in 3.34.0

  • fallow-configcrates.io

    fixed in 3.34.0

  • fallow-corecrates.io

    fixed in 3.34.0

References 5

GitHub · fallow-rs/fallow