Skip to main content
Menu
Advisories

Quadratic time and memory multi-host URL validation

GHSA-955G-X97G-8MCPPublished Updated GitHub

Description

Validating an untrusted URL with a long scheme and many hosts into a multi-host URL field (e.g. PostgresDsn) takes quadratic time and memory: an input of about a hundred kilobytes takes around a gigabyte of memory to validate.

Details

The parse_multihost_url() function (in pydantic-core/src/validators/url.rs) parses each host separately, prepending the whole URL prefix (including the scheme) to every one of them (L644-L649):

let extra_urls: Vec<Url> = hosts
    .iter()
    .map(|host| {
        let reconstructed_url = format!("{prefix}{host}");
        parse_url(&reconstructed_url, input, strict)
    })
    .collect::<ValResult<_>>()?;

As the scheme can be arbitrarily long, and is parsed and stored once per host, both time and memory grow quadratically with the input size. Allowed schemes (e.g. postgres for PostgresDsn) are only checked after parsing, so they don't prevent the issue.

The issue was fixed in commit github.com/pydantic/pydantic/commit/b4028f9d87e34750e53be0ba011d70f3c0fcc94e.

Impact

Denial of service through validation of untrusted input. Affected are applications validating untrusted strings into multi-host URL fields (PostgresDsn, MongoDsn, NatsDsn, or custom types built on MultiHostUrl).

Affected versions

References

GitHub · pydantic/pydantic