ice: add missing xa_destroy for sched_node_ids
- Published
- Last modified
- Where the record stands: published, rejected by its publisher, or superseded by another id.What do these mean? →
- published
- Whether CISA lists it in its Known Exploited Vulnerabilities catalog: proof that attackers are using it.What do these mean? →
- Not listed in CISA KEV
- Fix
- Fixed in 6.1.189, 6.6.158, 6.12.111, 6.18.53, 7.2.7
- Whether working attack code is public (Exploit-DB, Metasploit, Nuclei or GitHub). Public code makes attacks easier.What do these mean? →
- None on Exploit-DB, Metasploit or GitHub
Summary
In the Linux kernel, the following vulnerability has been resolved: ice: add missing xa_destroy for sched_node_ids Commit 16dfa49406bc ("ice: Introduce new parameters in ice_sched_node") added a sched_node_ids xarray to the port info structure, but never called xa_destroy on it. Since xarrays can allocate internal memory, this can result in a memory leak even if every element in the xarray has been removed. The xarray is currently embedded in the port_info structure. This appears to have been done because its use is within functions that take the port_info as a primary argument. However, this complicates managing the lifecycle of the field. The port_info structure is allocated in ice_init_hw() using devm, and it is not released until the devm cleanup when the driver is unloaded. The ice_init_hw() function is called in many places, including devlink reload, and possibly during DDP load after updating the Tx scheduler layout. Adding a call of xa_destroy to the ice_deinit_hw() causes Sashiko to raise multiple concerns due to potential ordering issues and possible ways that port_info could be a dangling reference. To handle this, move the sched_node_ids out of port_info and into the hw structure. All users of the array already have a pointer to hw anyways, and there is only one sched_node_ids per adapter. While here, remove the overly verbose comment explaining the nature of the sched_node_ids xarray. Add the missing xa_destroy to the cleanup path and to ice_deinit_hw(), ensuring that we properly release the xarray memory. This was caught by Sashiko during development of unrelated code.
Timeline
- CVE published
- Record last updated
Affected versions
- Linux Linux
From a388961be5ed8ee037ac68220e389bc4e9339a39 · fixed in 09a7cdf8fffb065a8aa30cfa604ff4a65cbf04c9; From 16dfa49406bc5e1f4cbb115027cbd719d7e6c930 · fixed in c075a91fe5762d314e6e182d37d29cf874bd314a; From 16dfa49406bc5e1f4cbb115027cbd719d7e6c930 · fixed in 44cdd6b7e036303f7fecf841cf23c05a4a4faf2d; From 16dfa49406bc5e1f4cbb115027cbd719d7e6c930 · fixed in f5463bc124c0d6f922e272336584730c5c61c4f1; From 16dfa49406bc5e1f4cbb115027cbd719d7e6c930 · fixed in d6f38fb12069fb1edf762962b5fcf3f42d643b47; From 16dfa49406bc5e1f4cbb115027cbd719d7e6c930 · fixed in 53432c4c3e869076350aef319534431af8ba99c1; From 6.1.95 · fixed in 6.1.189
- Linux Linux
6.2
- KernelLinux
fixed in 6.1.189; From 6.2.0 · fixed in 6.6.158; fixed in 6.12.111; From 6.7.0 · fixed in 6.18.53; From 6.13.0 · fixed in 7.2.7