lockd: fix swapped arguments in nlmsvc_match_ip()
- Published
- Last modified
- Where the record stands: published, rejected by its publisher, or superseded by another id.What do these mean? →
- published
- Whether CISA lists it in its Known Exploited Vulnerabilities catalog: proof that attackers are using it.What do these mean? →
- Not listed in CISA KEV
- Fix
- Fixed in 6.6.160, 6.12.112, 6.18.51, 7.2.4
- Whether working attack code is public (Exploit-DB, Metasploit, Nuclei or GitHub). Public code makes attacks easier.What do these mean? →
- None on Exploit-DB, Metasploit or GitHub
Summary
In the Linux kernel, the following vulnerability has been resolved: lockd: fix swapped arguments in nlmsvc_match_ip() When releasing locks by server IP address via /proc/fs/nfsd/unlock_ip, nlmsvc_unlock_all_by_ip() calls nlm_traverse_files() with the server sockaddr as the opaque @data argument: nlm_traverse_files(server_addr, nlmsvc_match_ip, NULL); The match callback is later invoked from nlm_traverse_locks() as: match(lockhost, host); where the first argument is the nlm_host that owns the lock, and the second argument is the @data that was originally passed down (here the server sockaddr). This is the convention every other match callback relies on (nlmsvc_mark_host(), nlmsvc_same_host(), nlmsvc_is_client()): arg1 is the real nlm_host, arg2 is the caller-supplied reference value. nlmsvc_match_ip() has had these two arguments reversed ever since the unlock-by-IP feature was introduced in commit 4373ea84c84d ("lockd: unlock lockd locks associated with a given server ip"): return rpc_cmp_addr(nlm_srcaddr(host), datap); Here @host is actually the server sockaddr, so nlm_srcaddr(host) dereferences a struct sockaddr as a struct nlm_host and reads garbage at the offset of h_srcaddr; meanwhile @datap is actually the lock owner's nlm_host but is compared as a sockaddr. As a result the comparison practically never matches and locks are not released for the requested IP. Swap the arguments so the lock owner's source address is compared against the requested server address: return rpc_cmp_addr(nlm_srcaddr(datap), (struct sockaddr *)host); [ cel: fix the misleading typedef parameter names too ]
Timeline
- CVE published
- Record last updated
Affected versions
- Linux Linux
From 4373ea84c84d8a96e99d3da99e813d3e36d1bd11 · fixed in 4fe2db296c9cd897dd1fe06cc0ae9cbc13beefc5; From 4373ea84c84d8a96e99d3da99e813d3e36d1bd11 · fixed in d34c2ac447fe0490ede828e0143e2cbcb59e6c77; From 4373ea84c84d8a96e99d3da99e813d3e36d1bd11 · fixed in 0d72e78c9d38d5377a059a4837f82b65b91cdcf6; From 4373ea84c84d8a96e99d3da99e813d3e36d1bd11 · fixed in 21bcb609e0ab1dd60f39ca3498f85808933bcc9f; From 4373ea84c84d8a96e99d3da99e813d3e36d1bd11 · fixed in b9060689f49dc663e9a3d069c4a65ff63a836e66
- Linux Linux
2.6.26
- KernelLinux
From 2.6.26 · fixed in 6.6.160; From 6.7.0 · fixed in 6.12.112; From 6.13.0 · fixed in 6.18.51; From 6.19.0 · fixed in 7.2.4