nfc: nci: fix double completion race in nci_data_exchange_complete
- Published
- Last modified
- Where the record stands: published, rejected by its publisher, or superseded by another id.What do these mean? →
- published
- Whether CISA lists it in its Known Exploited Vulnerabilities catalog: proof that attackers are using it.What do these mean? →
- Not listed in CISA KEV
- Fix
- Fixed in 5.10.270, 5.15.221, 6.1.188, 6.6.157, 6.12.110, and 3 more
- Whether working attack code is public (Exploit-DB, Metasploit, Nuclei or GitHub). Public code makes attacks easier.What do these mean? →
- None on Exploit-DB, Metasploit or GitHub
Summary
In the Linux kernel, the following vulnerability has been resolved: nfc: nci: fix double completion race in nci_data_exchange_complete nci_close_device() and nci_rx_work can both call nci_data_exchange_complete() concurrently. After commit 4527025d440ce8 ("nfc: nci: fix circular locking dependency in nci_close_device") moved flush_workqueue(ndev->rx_wq) after mutex_unlock(&ndev->req_lock), rx_work is no longer serialized with the explicit completion call in the close path. Both callers read the non-NULL callback pointer and invoke rawsock_data_exchange_complete(), which calls sock_put() -- but only one sock_hold() was taken, so the second sock_put() underflows the refcount and frees the socket while it is still in use. Replace the bare clear_bit(NCI_DATA_EXCHANGE) with test_and_clear_bit() so that only the first caller proceeds to invoke the callback.
Timeline
- CVE published
- Record last updated
Affected versions
- Linux Linux
From 7ed00a3edc8597fe2333f524401e2889aa1b5edf · fixed in 3f075832734005310740d148d1cf1c1e792ebdca; From 5eef9ebec7f5738f12cadede3545c05b34bf5ac3 · fixed in 588ccd19a6e69eca72d54608c3ab3b45709b2305; From ca54e904a071aa65ef3ad46ba42d51aaac6b73b4 · fixed in cf646a9f5554bc07d6ccb59c327812b3a0c6a368; From eb435d150ca74b4d40f77f1a2266f3636ed64a79 · fixed in 9030a1bbe2c6b1e3e54cef462d159b5248f09fd2; From 1edc12d2bbcb7a8d0f1088e6fccb9d8c01bb1289 · fixed in bfdf412208fea7fc0d5b32d68a35b25261917393; From d89b74bf08f067b55c03d7f999ba0a0e73177eb3 · fixed in ba4c776af3dc21ed04e315e6545e99703bb1b53a; From 4527025d440ce84bf56e75ce1df2e84cb8178616 · fixed in ee08414d78b851e3d1856d6e4d631939b01a1bbe; From 4527025d440ce84bf56e75ce1df2e84cb8178616 · fixed in 8265a626cc14a48e46e6dc8c47667e72b4232ac2; From 5.10.253 · fixed in 5.10.270; From 5.15.203 · fixed in 5.15.221; From 6.1.168 · fixed in 6.1.188; From 6.6.131 · fixed in 6.6.157; From 6.12.80 · fixed in 6.12.110; From 6.18.21 · fixed in 6.18.52; From 6.19.11 · fixed in 6.20
- Linux Linux
7.0
- KernelLinux
fixed in 5.10.270; From 5.11.0 · fixed in 5.15.221; From 5.16.0 · fixed in 6.1.188; From 6.2.0 · fixed in 6.6.157; From 6.7.0 · fixed in 6.12.110; From 6.13.0 · fixed in 6.18.52; From 6.19.0 · fixed in 7.2.6
References 8
git.kernel.org
- stable/c/3f075832734005310740d148d1cf1c1e792ebdca
- stable/c/588ccd19a6e69eca72d54608c3ab3b45709b2305
- stable/c/cf646a9f5554bc07d6ccb59c327812b3a0c6a368
- stable/c/9030a1bbe2c6b1e3e54cef462d159b5248f09fd2
- stable/c/bfdf412208fea7fc0d5b32d68a35b25261917393
- stable/c/ba4c776af3dc21ed04e315e6545e99703bb1b53a
- stable/c/ee08414d78b851e3d1856d6e4d631939b01a1bbe
- stable/c/8265a626cc14a48e46e6dc8c47667e72b4232ac2