scsi: qla2xxx: Fix BSG job leak on validate flash image error path
- Published
- Last modified
- Where the record stands: published, rejected by its publisher, or superseded by another id.What do these mean? →
- published
- Whether CISA lists it in its Known Exploited Vulnerabilities catalog: proof that attackers are using it.What do these mean? →
- Not listed in CISA KEV
- Fix
- Fixed in 5.11, 5.16, 6.2, 6.7, 6.13, and 3 more
- Whether working attack code is public (Exploit-DB, Metasploit, Nuclei or GitHub). Public code makes attacks easier.What do these mean? →
- None on Exploit-DB, Metasploit or GitHub
Summary
In the Linux kernel, the following vulnerability has been resolved: scsi: qla2xxx: Fix BSG job leak on validate flash image error path qla28xx_validate_flash_image() returns QLA_SUCCESS (0) unconditionally, telling the FC BSG transport (fc_bsg_host_dispatch()) that the driver owns and will complete the request. But bsg_job_done() is guarded by "if (!rval)", so on the error path (rval == -EINVAL) neither the driver nor the transport completes the job. The request dangles until it times out, leaking block layer resources. Commit c2c68225b145 ("scsi: qla2xxx: Fix bsg_done() causing double free") added the "if (!rval)" guard to a batch of BSG handlers. That is correct for handlers that also return the error code (the transport then completes the job once via fail_host_msg), but this function returns QLA_SUCCESS unconditionally, so the guard turned a correct single completion into a leak. Always call bsg_job_done(): bsg_reply->result is DID_OK and the error is reported in vendor_rsp[0], and since the function returns 0 the transport will not complete the job a second time.
Timeline
- CVE published
- Record last updated
Affected versions
- Linux Linux
From c2c68225b1456f4d0d393b5a8778d51bb0d5b1d0 · fixed in e25241f9fa01fb0c088381a156d84a725b71c1ef; From c2c68225b1456f4d0d393b5a8778d51bb0d5b1d0 · fixed in 0fb52cc632464b0cd07f970341330466d772efe1; From 5.10.251 · fixed in 5.11; From 5.15.201 · fixed in 5.16; From 6.1.164 · fixed in 6.2; From 6.6.127 · fixed in 6.7; From 6.12.74 · fixed in 6.13; From 6.18.13 · fixed in 6.19; From 6.19.3 · fixed in 6.20
- Linux Linux
7.0
- KernelLinux
From 7.0.0 · fixed in 7.2.5