nfsd: revoke copy-notify stateids before dropping their reference

Summary

In the Linux kernel, the following vulnerability has been resolved: nfsd: revoke copy-notify stateids before dropping their reference Copy-notify stateids live in the s2s_cp_stateids IDR and on their parent stid's sc_cp_list, pinned by a single membership reference. _free_cpntf_state_locked() only unlinks an entry once its refcount reaches zero, so any revoke path that runs while a concurrent find_cpntf_state()/manage_cpntf_state() holder has elevated cs_count drops the reference without unlinking, leaving the entry discoverable with its membership reference already consumed. A second revoke or a laundromat tick then frees it while the reader still holds the pointer -- a KASAN-detectable use-after-free at the reader's nfs4_put_cpntf_state(). This affected all three revoke paths: • The parent-stid drain (nfs4_free_cpntf_statelist()) repeatedly called _free_cpntf_state_locked() on the first list entry; a holder that had bumped cs_count made it return early, so the next iteration re-decremented and burned the holder's reference. • OFFLOAD_CANCEL (manage_cpntf_state()) and laundromat expiry likewise used _free_cpntf_state_locked() and could drop 2->1 without unlinking. Add revoke_cpntf_state_locked(), which unhashes the entry from the IDR and sc_cp_list first (deferring the final free to any holder), and use it from all three revoke paths. The drain now walks with list_for_each_entry_safe() and revokes each entry unconditionally, so it terminates in one pass per entry regardless of cs_count. The unhash is gated on !list_empty(&cps->cp_list); the idr_remove() gate matters because idr_alloc_cyclic() may have recycled the so_id by then. Keep _free_cpntf_state_locked() for the reference-holder put path only, where a concurrent revoke may already have unlinked the entry (its list_del_init() then a no-op).

Timeline

1. Sep 11, 2026, 7:45 PM UTCCVE published
2. Oct 19, 2026, 8:50 AM UTCRecord last updated

Affected versions

• Linux Linux

  From 624322f1adc58acd0b69f77a6ddc764207e97241 · fixed in 5f00e0ab4de45d4f9e4bd0883cf2517acf63fc0d; From 624322f1adc58acd0b69f77a6ddc764207e97241 · fixed in 06a62f6dbc60791f4229c6950b1eec6b18df9af1; From 624322f1adc58acd0b69f77a6ddc764207e97241 · fixed in a1fca0f7bbb7b100a39c7ba8dd7922c87c4237a3; From 624322f1adc58acd0b69f77a6ddc764207e97241 · fixed in caddbeffab1eaba1d2bcf5ceda35547863466705; From 624322f1adc58acd0b69f77a6ddc764207e97241 · fixed in 6b8149448cdcb476fba4559d1ecc247efee9971b; From 624322f1adc58acd0b69f77a6ddc764207e97241 · fixed in b56d2c5f01cddbeca7d11cce81d97db4ec9a464f; From 624322f1adc58acd0b69f77a6ddc764207e97241 · fixed in ff8a3cff02b92b2a82f1a9876038fcf953ae9c25; From 624322f1adc58acd0b69f77a6ddc764207e97241 · fixed in 3b0c3595db99bb4bebd7c8aa8a36f3c50e411bb7

• Linux Linux

  5.6

• KernelLinux

  From 5.6.0 · fixed in 5.10.270; From 5.11.0 · fixed in 5.15.221; From 5.16.0 · fixed in 6.1.188; From 6.2.0 · fixed in 6.6.157; From 6.7.0 · fixed in 6.12.109; From 6.13.0 · fixed in 6.18.50; From 6.19.0 · fixed in 7.2.4

References 8