xfs: bounds-check buffer log item's dirty bitmap
- Published
- Last modified
- Where the record stands: published, rejected by its publisher, or superseded by another id.What do these mean? →
- published
- Whether CISA lists it in its Known Exploited Vulnerabilities catalog: proof that attackers are using it.What do these mean? →
- Not listed in CISA KEV
- Fix
- Fixed in 5.10.267, 5.15.218, 6.1.185, 6.6.154, 6.12.106, and 2 more
- Whether working attack code is public (Exploit-DB, Metasploit, Nuclei or GitHub). Public code makes attacks easier.What do these mean? →
- None on Exploit-DB, Metasploit or GitHub
- Exploitation: none
- Automatable: no
- Technical impact: total
Summary
In the Linux kernel, the following vulnerability has been resolved: xfs: bounds-check buffer log item's dirty bitmap xlog_recover_do_reg_buffer() replays each dirty region described by a buffer log item's bitmap into the buffer read for that item: memcpy(xfs_buf_offset(bp, (uint)bit << XFS_BLF_SHIFT), item->ri_buf[i].iov_base, nbits << XFS_BLF_SHIFT); The destination offset (bit/nbits, from the logged dirty bitmap) and the buffer size (from the logged blf_len) are both attacker-controlled and otherwise unrelated, yet the only thing bounding the copy is an ASSERT(), which compiles away on production kernels. A crafted image logging a small blf_len together with a bitmap bit past the end of that buffer drives the memcpy() past the buffer's allocation, corrupting adjacent kernel heap during mount-time log recovery. This is reachable by anyone who can get a crafted image mounted -- the malicious-filesystem threat model XFS already guards against elsewhere. Turn the ASSERT() into a real XFS_IS_CORRUPT() check that aborts recovery of the buffer with -EFSCORRUPTED, consistent with the validate-and-fail idiom already used in xlog_recover_do_inode_buffer() and xfs_dquot_item_recover.c. xlog_recover_do_reg_buffer() therefore becomes STATIC int and its three callers propagate the error. Found and confirmed with KASAN on a CONFIG_XFS_DEBUG=n build: the crafted image trips a slab-out-of-bounds write before this change and fails recovery cleanly with -EFSCORRUPTED after it.
Timeline
- CVE published
- CISA SSVC assessment
Exploitation: none · Automatable: no · Technical impact: total
- Record last updated
Affected versions
- Linux Linux
From 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 · fixed in acb4e26295e7f0e685815a3fd3d70bd8329cefa1; From 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 · fixed in f3859c35a4fbc1c1c58431f684f808e43696891d; From 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 · fixed in f7b5fa83e2c192be922121b764415fa8c7549ea1; From 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 · fixed in b7528b42813f02724a78fce1da24d69d1bfc4d38; From 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 · fixed in 7e32d4eebae6ca24f8a673c107fd7eca1f47afc2; From 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 · fixed in f8288214459ead7e87d26e5822f62c14a4f2ed6b; From 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 · fixed in edaf5b6bd625356893da20d69a259b34a9de2694; From 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 · fixed in 813f8136a2ce1fee266d02a7df73db6e8a541604
- Linux Linux
2.6.12
- KernelLinux
From 2.6.12 · fixed in 5.10.267; From 5.11.0 · fixed in 5.15.218; From 5.16.0 · fixed in 6.1.185; From 6.2.0 · fixed in 6.6.154; From 6.7.0 · fixed in 6.12.106; From 6.13.0 · fixed in 6.18.46; From 6.19.0 · fixed in 7.1.10
References 8
git.kernel.org
- stable/c/acb4e26295e7f0e685815a3fd3d70bd8329cefa1
- stable/c/f3859c35a4fbc1c1c58431f684f808e43696891d
- stable/c/f7b5fa83e2c192be922121b764415fa8c7549ea1
- stable/c/b7528b42813f02724a78fce1da24d69d1bfc4d38
- stable/c/7e32d4eebae6ca24f8a673c107fd7eca1f47afc2
- stable/c/f8288214459ead7e87d26e5822f62c14a4f2ed6b
- stable/c/edaf5b6bd625356893da20d69a259b34a9de2694
- stable/c/813f8136a2ce1fee266d02a7df73db6e8a541604