netrom: Fix a memory leak in nr_heartbeat_expiry()
- Published
- Last modified
- Where the record stands: published, rejected by its publisher, or superseded by another id.What do these mean? →
- published
- Whether CISA lists it in its Known Exploited Vulnerabilities catalog: proof that attackers are using it.What do these mean? →
- Not listed in CISA KEV
- Fix
- Fixed in 4.19.317, 5.4.279, 5.10.221, 5.15.162, 6.1.96, and 3 more
- Whether working attack code is public (Exploit-DB, Metasploit, Nuclei or GitHub). Public code makes attacks easier.What do these mean? →
- None on Exploit-DB, Metasploit or GitHub
- Exploitation: none
- Automatable: no
- Technical impact: partial
Summary
In the Linux kernel, the following vulnerability has been resolved: netrom: Fix a memory leak in nr_heartbeat_expiry() syzbot reported a memory leak in nr_create() [0]. Commit 409db27e3a2e ("netrom: Fix use-after-free of a listening socket.") added sock_hold() to the nr_heartbeat_expiry() function, where a) a socket has a SOCK_DESTROY flag or b) a listening socket has a SOCK_DEAD flag. But in the case "a," when the SOCK_DESTROY flag is set, the file descriptor has already been closed and the nr_release() function has been called. So it makes no sense to hold the reference count because no one will call another nr_destroy_socket() and put it as in the case "b." nr_connect nr_establish_data_link nr_start_heartbeat nr_release switch (nr->state) case NR_STATE_3 nr->state = NR_STATE_2 sock_set_flag(sk, SOCK_DESTROY); nr_rx_frame nr_process_rx_frame switch (nr->state) case NR_STATE_2 nr_state2_machine() nr_disconnect() nr_sk(sk)->state = NR_STATE_0 sock_set_flag(sk, SOCK_DEAD) nr_heartbeat_expiry switch (nr->state) case NR_STATE_0 if (sock_flag(sk, SOCK_DESTROY) || (sk->sk_state == TCP_LISTEN && sock_flag(sk, SOCK_DEAD))) sock_hold() // ( !!! ) nr_destroy_socket() To fix the memory leak, let's call sock_hold() only for a listening socket. Found by InfoTeCS on behalf of Linux Verification Center (linuxtesting.org) with Syzkaller. [0]: https://syzkaller.appspot.com/bug?extid=d327a1f3b12e1e206c16
Timeline
- CVE published
- CISA SSVC assessment
Exploitation: none · Automatable: no · Technical impact: partial
- Record last updated
Affected versions
- Linux Linux
From a31caf5779ace8fa98b0d454133808e082ee7a1b · fixed in d616876256b38ecf9a1a1c7d674192c5346bc69c; From fe9b9e621cebe6b7e83f7e954c70f8bb430520e5 · fixed in e07a9c2a850cdebf625e7a1b8171bd23a8554313; From 7de16d75b20ab13b75a7291f449a1b00090edfea · fixed in 5391f9db2cab5ef1cb411be1ab7dbec728078fba; From d2d3ab1b1de3302de2c85769121fd4f890e47ceb · fixed in 280cf1173726a7059b628c610c71050d5c0b6937; From 51e394c6f81adbfe7c34d15f58b3d4d44f144acf · fixed in a02fd5d775cf9787ee7698c797e20f2fa13d2e2b; From 409db27e3a2eb5e8ef7226ca33be33361b3ed1c9 · fixed in b6ebe4fed73eedeb73f4540f8edc4871945474c8; From 409db27e3a2eb5e8ef7226ca33be33361b3ed1c9 · fixed in d377f5a28332954b19e373d36823e59830ab1712; From 409db27e3a2eb5e8ef7226ca33be33361b3ed1c9 · fixed in 0b9130247f3b6a1122478471ff0e014ea96bb735; From 4.19.272 · fixed in 4.19.317; From 5.4.231 · fixed in 5.4.279; From 5.10.166 · fixed in 5.10.221; From 5.15.91 · fixed in 5.15.162; From 6.1.9 · fixed in 6.1.96; From 4.14.305 · fixed in 4.15
- Linux Linux
6.2
- KernelLinux
fixed in 4.19.317; From 4.20.0 · fixed in 5.4.279; From 5.5.0 · fixed in 5.10.221; From 5.11.0 · fixed in 5.15.162; From 5.16.0 · fixed in 6.1.96; From 6.2.0 · fixed in 6.6.36; fixed in 6.9.7
References 8
git.kernel.org
- stable/c/d616876256b38ecf9a1a1c7d674192c5346bc69c
- stable/c/e07a9c2a850cdebf625e7a1b8171bd23a8554313
- stable/c/5391f9db2cab5ef1cb411be1ab7dbec728078fba
- stable/c/280cf1173726a7059b628c610c71050d5c0b6937
- stable/c/a02fd5d775cf9787ee7698c797e20f2fa13d2e2b
- stable/c/b6ebe4fed73eedeb73f4540f8edc4871945474c8
- stable/c/d377f5a28332954b19e373d36823e59830ab1712
- stable/c/0b9130247f3b6a1122478471ff0e014ea96bb735