Segfault on strings tensors with mistmatched dimensions in TensorFlow

Summary

TensorFlow is an end-to-end open source platform for machine learning. In affected versions under certain conditions, Go code can trigger a segfault in string deallocation. For string tensors, `C.TF_TString_Dealloc` is called during garbage collection within a finalizer function. However, tensor structure isn't checked until encoding to avoid a performance penalty. The current method for dealloc assumes that encoding succeeded, but segfaults when a string tensor is garbage collected whose encoding failed (e.g., due to mismatched dimensions). To fix this, the call to set the finalizer function is deferred until `NewTensor` returns and, if encoding failed for a string tensor, deallocs are determined based on bytes written. We have patched the issue in GitHub commit 8721ba96e5760c229217b594f6d2ba332beedf22. The fix will be included in TensorFlow 2.6.0. We will also cherrypick this commit on TensorFlow 2.5.1, which is the other affected version.

Timeline

1. Aug 12, 2021, 11:00 PM UTCCVE published
2. Aug 4, 2024, 1:23 AM UTCRecord last updated

Affected versions

• tensorflow tensorflow

  From 2.5.0 · fixed in 2.5.1

• tensorflowPyPI

  From 2.3.0 · fixed in 2.3.4; From 2.4.0 · fixed in 2.4.3

• tensorflowPyPI

  From 2.5.0rc0 · fixed in 2.5.1

• tensorflow-cpuPyPI

  From 2.5.0rc0 · fixed in 2.5.1

• tensorflow-gpuPyPI

  From 2.5.0rc0 · fixed in 2.5.1

• tensorflow-cpuPyPI

  From 2.3.0 · fixed in 2.3.4; From 2.4.0 · fixed in 2.4.3

• tensorflow-gpuPyPI

  From 2.3.0 · fixed in 2.3.4; From 2.4.0 · fixed in 2.4.3

References 3