Use after free and segfault in shape inference functions in TensorFlow

Summary

TensorFlow is an end-to-end open source platform for machine learning. In affected versions when running shape functions, some functions (such as `MutableHashTableShape`) produce extra output information in the form of a `ShapeAndType` struct. The shapes embedded in this struct are owned by an inference context that is cleaned up almost immediately; if the upstream code attempts to access this shape information, it can trigger a segfault. `ShapeRefiner` is mitigating this for normal output shapes by cloning them (and thus putting the newly created shape under ownership of an inference context that will not die), but we were not doing the same for shapes and types. This commit fixes that by doing similar logic on output shapes and types. We have patched the issue in GitHub commit ee119d4a498979525046fba1c3dd3f13a039fbb1. The fix will be included in TensorFlow 2.6.0. We will also cherrypick this commit on TensorFlow 2.5.1, TensorFlow 2.4.3, and TensorFlow 2.3.4, as these are also affected and still in supported range.

Timeline

1. Aug 12, 2021, 11:10 PM UTCCVE published
2. Aug 4, 2024, 1:23 AM UTCRecord last updated

Affected versions

• tensorflow tensorflow

  From 2.5.0 · fixed in 2.5.1; From 2.4.0 · fixed in 2.4.3; fixed in 2.3.4

• tensorflow-gpuPyPI

  From 2.3.0 · fixed in 2.3.4; From 2.4.0 · fixed in 2.4.3

• tensorflowPyPI

  fixed in 2.3.4

• tensorflowPyPI

  From 2.4.0 · fixed in 2.4.3

• tensorflowPyPI

  From 2.5.0 · fixed in 2.5.1

• tensorflow-cpuPyPI

  fixed in 2.3.4

• tensorflow-cpuPyPI

  From 2.4.0 · fixed in 2.4.3

• tensorflow-cpuPyPI

  From 2.5.0 · fixed in 2.5.1

• tensorflow-gpuPyPI

  fixed in 2.3.4

• tensorflow-gpuPyPI

  From 2.4.0 · fixed in 2.4.3

• tensorflow-gpuPyPI

  From 2.5.0 · fixed in 2.5.1

• tensorflowPyPI

  From 2.3.0 · fixed in 2.3.4; From 2.4.0 · fixed in 2.4.3

• tensorflow-cpuPyPI

  From 2.3.0 · fixed in 2.3.4; From 2.4.0 · fixed in 2.4.3

References 2