Incorrect authorization in OAuth2-Proxy

Summary

OAuth2-Proxy is an open source reverse proxy that provides authentication with Google, Github or other providers. The `--gitlab-group` flag for group-based authorization in the GitLab provider stopped working in the v7.0.0 release. Regardless of the flag settings, authorization wasn't restricted. Additionally, any authenticated users had whichever groups were set in `--gitlab-group` added to the new `X-Forwarded-Groups` header to the upstream application. While adding GitLab project based authorization support in #630, a bug was introduced where the user session's groups field was populated with the `--gitlab-group` config entries instead of pulling the individual user's group membership from the GitLab Userinfo endpoint. When the session groups where compared against the allowed groups for authorization, they matched improperly (since both lists were populated with the same data) so authorization was allowed. This impacts GitLab Provider users who relies on group membership for authorization restrictions. Any authenticated users in your GitLab environment can access your applications regardless of `--gitlab-group` membership restrictions. This is patched in v7.1.0. There is no workaround for the Group membership bug. But `--gitlab-project` can be set to use Project membership as the authorization checks instead of groups; it is not broken.

Timeline

1. Mar 26, 2021, 8:55 PM UTCCVE published
2. Aug 3, 2024, 6:09 PM UTCRecord last updated

Affected versions

• oauth2-proxy oauth2-proxy

  From 7.0.0 · fixed in 7.1.0

• github.com/oauth2-proxy/oauth2-proxyGo

  All versions

• github.com/oauth2-proxy/oauth2-proxy/v7Go

  fixed in 7.1.0

References 5